Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Contact form component #1453

Merged
merged 5 commits into from
Oct 23, 2023
Merged

feat: Contact form component #1453

merged 5 commits into from
Oct 23, 2023

Conversation

matthieujacq
Copy link
Contributor

@matthieujacq matthieujacq commented Oct 20, 2023

Description

Only the form, no validation, no post to the server.

Screenshots (if appropriate):

🖥️ Desktop

image

After submitting:
image

📱 Mobile

image

@matthieujacq matthieujacq added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 20, 2023
@matthieujacq matthieujacq self-assigned this Oct 20, 2023
@matthieujacq matthieujacq temporarily deployed to preview October 20, 2023 16:27 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 9:32am
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 9:32am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 9:32am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/contact/components/ContactForm.tsx

The handleSubmit function currently logs the email and message to the console. This is not a good practice for production code as it could potentially expose sensitive user information. Consider replacing the console log with an actual form submission logic. For example:

const handleSubmit = (event: React.FormEvent) => {
  event.preventDefault();
  // Submit form
};

Also, the form does not have an onSubmit event. It's better to handle form submission with the onSubmit event of the form itself rather than the onClick event of the submit button. This way, the form will also be submitted when the user presses the enter key.

<form onSubmit={handleSubmit}>
  ...
</form>

🔒📧🔘


Powered by Code Review GPT

@StanGirard
Copy link
Collaborator

@mamadoudicko

@matthieujacq matthieujacq merged commit 7d40a27 into main Oct 23, 2023
3 of 4 checks passed
mamadoudicko pushed a commit that referenced this pull request Oct 23, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.95 (2023-10-23)

## What's Changed
* feat: homepage first section by @matthieujacq in
#1439
* fix: show a flat gradient in the UseCase section by @matthieujacq in
#1440
* style: update testimonials display by @mamadoudicko in
#1441
* feat: fetch homepage data from CMS by @mamadoudicko in
#1452
* feat: contact sales page (front layout) by @matthieujacq in
#1451
* Fix: Improved Text Visibility in Dark Mode in OnboardingQuestion
Component by @Dev-Dz27 in #1456
* feat(cms): added single video demo by @StanGirard in
#1459
* feat: fetch demo video from CMS by @mamadoudicko in
#1461
* feat: Contact form component by @matthieujacq in
#1453

## New Contributors
* @Dev-Dz27 made their first contribution in
#1456

**Full Changelog**:
v0.0.94...v0.0.95

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.95 (2023-10-23)

## What's Changed
* feat: homepage first section by @matthieujacq in
QuivrHQ/quivr#1439
* fix: show a flat gradient in the UseCase section by @matthieujacq in
QuivrHQ/quivr#1440
* style: update testimonials display by @mamadoudicko in
QuivrHQ/quivr#1441
* feat: fetch homepage data from CMS by @mamadoudicko in
QuivrHQ/quivr#1452
* feat: contact sales page (front layout) by @matthieujacq in
QuivrHQ/quivr#1451
* Fix: Improved Text Visibility in Dark Mode in OnboardingQuestion
Component by @Dev-Dz27 in QuivrHQ/quivr#1456
* feat(cms): added single video demo by @StanGirard in
QuivrHQ/quivr#1459
* feat: fetch demo video from CMS by @mamadoudicko in
QuivrHQ/quivr#1461
* feat: Contact form component by @matthieujacq in
QuivrHQ/quivr#1453

## New Contributors
* @Dev-Dz27 made their first contribution in
QuivrHQ/quivr#1456

**Full Changelog**:
QuivrHQ/quivr@v0.0.94...v0.0.95

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants